verify hooks#656
Closed
mishaschwartz wants to merge 1 commit into
Closed
Conversation
3 tasks
fmigneault
reviewed
May 22, 2026
fmigneault
left a comment
fmigneault
left a comment
Member
There was a problem hiding this comment.
Will need the corresponding updates when available (from bird-house/twitcher#151):
Line 18 in 9a35799
Line 6 in 9a35799
| """ | ||
| def _discover_hooks(self, instance, service_name, hook_type, method, path, query): | ||
| # type: (Union[Request, Response], Str, ServiceHookType, Str, Str, Str, bool) -> Iterable[Tuple[Callable, Str, Str]] | ||
| """Yields hook functions.""" |
Member
There was a problem hiding this comment.
Use the multiline docstring.
Same for others.
Comment on lines
+428
to
+429
| .. versionadded:: 5.0.3 | ||
| Requires ``Twitcher >= 0.11.2``. |
Member
There was a problem hiding this comment.
magpie 5.2.0
twitcher 0.12.0
Collaborator
Author
|
This feature is no longer needed and I'm not convinced that this makes sense really to be able to short-circuit the entire auth mechanism set up by magpie and twitcher. If anyone is interested in revisiting this later please feel free to re-open this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add new hook type which is called before verify and can be used to force the verify endpoint to return a "403" response.
Must be implemented with bird-house/twitcher#151
TODO: